Skip to content

fix(instrumentation-express): set correct http.route to root span #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DmytryS wants to merge 1 commit into from
Closed

fix(instrumentation-express): set correct http.route to root span #2245

DmytryS wants to merge 1 commit into from

Conversation

@DmytryS
Copy link

@DmytryS DmytryS commented May 27, 2024 •
edited
Loading

Which problem is this PR solving?

Short description of the changes

  • When capturing endpoint route - ignore it if it's shorter than saved one.
image image

@DmytryS DmytryS requested a review from a team May 27, 2024 16:47
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 27, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: DmytryS / name: Dmytro Shvaika (d81835f)

@github-actions github-actions bot requested review from JamieDanielson and pkanal May 27, 2024 16:47
@DmytryS DmytryS requested a review from a team as a code owner October 21, 2024 16:56
@DmytryS DmytryS changed the title fix(express): get route fix(instrumentation-express):set correct http.route to root span Oct 21, 2024
@DmytryS DmytryS changed the title fix(instrumentation-express):set correct http.route to root span fix: set correct http.route to root span Oct 21, 2024
@DmytryS DmytryS changed the title fix: set correct http.route to root span @opentelemetry/instrumentation-express: set correct http.route to root span Jan 23, 2025
@DmytryS DmytryS force-pushed the fix/express-route branch from 93e45e1 to aaec678 Compare March 11, 2025 12:47
@github-actions github-actions bot requested review from d4nyll, maryliag and seemk March 11, 2025 12:48
@DmytryS DmytryS changed the title @opentelemetry/instrumentation-express: set correct http.route to root span fix(instrumentation-express): set correct http.route to root span Mar 11, 2025
@DmytryS
Copy link
Author

DmytryS commented Mar 11, 2025

Hi @JamieDanielson, @pkanal ? ...is there any way this small PR could be reviewed/merged? This is affecting some of our customers and it's been open for a while. Thanks!

@DmytryS DmytryS force-pushed the fix/express-route branch from b77b969 to d81835f Compare March 11, 2025 12:58
@JamieDanielson
Copy link
Member

JamieDanielson commented May 22, 2025

Looks like this was superseded by #2682 .

@raphael-theriault-swi raphael-theriault-swi mentioned this pull request Jul 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamieDanielson JamieDanielson Awaiting requested review from JamieDanielson

@pkanal pkanal Awaiting requested review from pkanal

@raphael-theriault-swi raphael-theriault-swi Awaiting requested review from raphael-theriault-swi

@d4nyll d4nyll Awaiting requested review from d4nyll

@maryliag maryliag Awaiting requested review from maryliag

@seemk seemk Awaiting requested review from seemk

Assignees

@maryliag maryliag

@seemk seemk

@pkanal pkanal

@d4nyll d4nyll

@JamieDanielson JamieDanielson

@raphael-theriault-swi raphael-theriault-swi

Labels

pkg:instrumentation-express pkg:instrumentation-pg pkg:instrumentation-runtime-node pkg:instrumentation-winston

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@opentelemetry/instrumentation-express - incorrect route set to span attributes

7 participants

@DmytryS @JamieDanielson @maryliag @seemk @pkanal @d4nyll @raphael-theriault-swi